Show Idle (>14 d.) Chans


← 2020-06-13 | 2020-06-15 →
billymg: jfw: yeah, there's definitley a lot more that can be removed. i even managed to get a few more easy snips in on this patch (down to ~89k total lines now) by removing some extraneous filesystem libraries
billymg: i just deployed to billymg.com, so it's live now
billymg: i think for the next slimming patch i might try to write a script to do some static analysis of which methods are created but never called
billymg: jfw: out of those extra lines removed almost 6k was for a zip archive library lol
billymg: previously used for people who wanted to "install" plugins via the web UI (or maybe it was themes, or both), rather than just manually copying them to their respective directories
jfw: billymg: the ad-hoc, informally specified, bug-ridden and slow implementation of half of V, aha
diana_coman: billymg - iirc some of your changes did touch the default theme(s) so hm, if I nuked those entirely and have my own, what do I need to port over?
billymg: diana_coman: you mean some of my changes in previous patches? (but yes, this one removed some bits from the included themes as well)
diana_coman: yes, I mean some of the changes in previous patches (I didn't see this patch at all, yet)
billymg: diana_coman: hrm, i think the only changes were for the js text selection thing, which was later removed by jfw
billymg: so that one can be safely ignored
diana_coman: cool then
billymg: diana_coman: yeah, i would recommend just keeping the directory of your current custom theme as is. the included themes can be safely nuked for sure (server-side selection is handled in the footnotes.php as of this patch)
billymg: same for anyone else considering using this patch, if you spent any time customizing your theme just keep as is
billymg: i'll try to get it posted later today or tomorrow. i hadn't done a full fresh deploy since the patch removing tinymce and so i had to double and triple check everything before flipping the switch
diana_coman: billymg no rush at all
← 2020-06-13 | 2020-06-15 →